Uploaded image for project: 'Liferay Apps'
  1. Liferay Apps
  2. LRA-66

Several front end improvements to People Directory portlet

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: None
    • Labels:
      None

      Description

      +) Number of Rows: <aui:input type="text" name="rowCount" value="<%=rowCount%>" label=""/>
         Alloy UI already supports label. Why not use that and language.properties?
        
      +) The below global variables should not be used. Any other similarly written portlet may override the resourceURL.

      <script type="text/javascript">
              var rowCount = parseInt("<%=rowCount%>");
              var portletNamespace = "<portlet:namespace />";
              var resourceUrl = "<portlet:resourceURL />";
      </script>

      +) Profile.jsp
          Move the styles to css file.

      +) View.jsp
          Consolidate style in css file

      8) main.js
          use templates for the html code in js
          remove any commented alert statements

        Attachments

          Activity

            People

            • Assignee:
              alejandro.soto Alejandro Soto [X] (Inactive)
              Reporter:
              mcalvo mcalvo
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support