-
Type:
Improvement
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: None
-
Labels:None
+) Number of Rows: <aui:input type="text" name="rowCount" value="<%=rowCount%>" label=""/>
Alloy UI already supports label. Why not use that and language.properties?
+) The below global variables should not be used. Any other similarly written portlet may override the resourceURL.
<script type="text/javascript">
var rowCount = parseInt("<%=rowCount%>");
var portletNamespace = "<portlet:namespace />";
var resourceUrl = "<portlet:resourceURL />";
</script>
+) Profile.jsp
Move the styles to css file.
+) View.jsp
Consolidate style in css file
8) main.js
use templates for the html code in js
remove any commented alert statements
Alloy UI already supports label. Why not use that and language.properties?
+) The below global variables should not be used. Any other similarly written portlet may override the resourceURL.
<script type="text/javascript">
var rowCount = parseInt("<%=rowCount%>");
var portletNamespace = "<portlet:namespace />";
var resourceUrl = "<portlet:resourceURL />";
</script>
+) Profile.jsp
Move the styles to css file.
+) View.jsp
Consolidate style in css file
8) main.js
use templates for the html code in js
remove any commented alert statements