-
Type:
Task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: None
-
Labels:None
Get the code from SVN:
https://svn.rivetlogic.com/repos/rivets/archives/hrportal/branches/6.2%20CE%20GA%201/liferay-plugins-sdk-6.2.0/portlets/events-management-portlet/
1) Let's take hr-portal reference from portlet.properties and other places
2) Why are we using a custom query to find by eventId and email when the same can be done easily in service builder?
3) The email that went out did not have appropriate subject and body
4) As soon as an event is stored, the UI renders sometimes two rows and sometimes no rows. Refreshing the screen tries to re-post.
we need to show appropriate results and the redirected one should be a render url to the same page.
5) All the action urls should redirect to render url at the end of action so that refreshing the screen does not trigger another post.
6) Provide language properties for all definition of terms
7) Event creation should not allow events in past. This sends the event directly to past events and does not allow a user to edit.
8) We need a message to say an email id that is already registered for an event cannot be registered again.
9) Can we use Liferay's repeatable fields for adding more participant?
10) Move styles to css - edit_event.jsp
type="submit" style="height: 25px;"
11) typo in file name - emai-from.jspf
12) upload_csv.jsp - this is not used. remove from repo.
<div>
<label for="firstname">Upload file:</label>
<input type="file" name="csvFile" />
</div>
13) Check PACL security is enabled.
14) It is sending the email reporting an email address different than what it is configured in portlet preferences.
15) The default "Updated Invitation email" is not good. It is not asking to confirm the assistance.
16) Check the copyrights are in .js, .jsp, and .java.
Additionally:
+ Change "magic" numbers and String values for constants.
+ Remove any console.log
+ Remove welcome-file-list from web.xml
+ Change any e.printStackTrace(); for log
https://svn.rivetlogic.com/repos/rivets/archives/hrportal/branches/6.2%20CE%20GA%201/liferay-plugins-sdk-6.2.0/portlets/events-management-portlet/
1) Let's take hr-portal reference from portlet.properties and other places
2) Why are we using a custom query to find by eventId and email when the same can be done easily in service builder?
3) The email that went out did not have appropriate subject and body
4) As soon as an event is stored, the UI renders sometimes two rows and sometimes no rows. Refreshing the screen tries to re-post.
we need to show appropriate results and the redirected one should be a render url to the same page.
5) All the action urls should redirect to render url at the end of action so that refreshing the screen does not trigger another post.
6) Provide language properties for all definition of terms
7) Event creation should not allow events in past. This sends the event directly to past events and does not allow a user to edit.
8) We need a message to say an email id that is already registered for an event cannot be registered again.
9) Can we use Liferay's repeatable fields for adding more participant?
10) Move styles to css - edit_event.jsp
type="submit" style="height: 25px;"
11) typo in file name - emai-from.jspf
12) upload_csv.jsp - this is not used. remove from repo.
<div>
<label for="firstname">Upload file:</label>
<input type="file" name="csvFile" />
</div>
13) Check PACL security is enabled.
14) It is sending the email reporting an email address different than what it is configured in portlet preferences.
15) The default "Updated Invitation email" is not good. It is not asking to confirm the assistance.
16) Check the copyrights are in .js, .jsp, and .java.
Additionally:
+ Change "magic" numbers and String values for constants.
+ Remove any console.log
+ Remove welcome-file-list from web.xml
+ Change any e.printStackTrace(); for log