bugs-24-04-14.png
ui-error-people-directory.png
[LRA-115] People Directory bugs Created: 31/Mar/14 Updated: 24/Apr/14 Resolved: 24/Apr/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | Juan Carrillo [X] (Inactive) | Assignee: | Alejandro Soto [X] (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
bugs-24-04-14.png
ui-error-people-directory.png
|
| Description |
|
People directory app on liferay marketplace is buggy and needs UI fixes.
Error in backend when clickin in an user link on search container Caused by: org.apache.jasper.JasperException: An exception occurred processing JSP page /html/profile.jsp at line 23__20: <%@ include file="init.jsp"%>_21: _22: <%_23: User userSelected = UserLocalServiceUtil.getUser(ParamUtil.getLong(_24: request, "userId"));_25: String backURL = ParamUtil.getString(request, "backURL");_26: String imageId = userSelected.getUserId() + "-picture";___Stacktrace: [Sanitized] Also found hardcoded templates in javascript var PEOPLE_DIRECTORY_TEMPLATES = { searchResultsHeader: '<div class="results">Total: {total} user{pluralization} found</div>', UI errors attached. |
| Comments |
| Comment by mcalvo [ 31/Mar/14 ] |
|
Please fix only the backend issues:
+ Use of constants + Error when selecting an user. + Please check all the items in this check list: http://wiki.rivetlogic.com/display/HRPORTAL/Development+ready+checklist Once you are done, the front end part will be assigned to someone else. |
| Comment by Juan Carrillo [X] (Inactive) [ 01/Apr/14 ] |
|
The only error that remains is this, we should not use UploadPortletRequest
public void serveResource(ResourceRequest resourceRequest, ResourceResponse resourceResponse) throws IOException, PortletException { UploadPortletRequest uploadRequest = PortalUtil.getUploadPortletRequest(resourceRequest); - and check all the functionality |
| Comment by Juan Carrillo [X] (Inactive) [ 03/Apr/14 ] |
| pull request is done |
| Comment by Juan Carrillo [X] (Inactive) [ 24/Apr/14 ] |
|
Responsive style issues
|
| Comment by Juan Carrillo [X] (Inactive) [ 24/Apr/14 ] |
|
Fernando was helping me solving the UI issues, but I cannot complete them.
These are the UI fixes that we have to fix: 1) The User information should go down the image when is on phone screen width. In the image there is a red cross, that space should not be empty. 2) Some text is getting out the info container. 3) Input search is getting out the portlet container Screenshot is taken in Chrome Browser. |
| Comment by mcalvo [ 24/Apr/14 ] |
|
Get the latest code from here: https://github.com/rivetlogic/mobile-people-directory |
| Comment by Alejandro Soto [X] (Inactive) [ 24/Apr/14 ] |
| ui fixes added and pull request sent |