[LRA-122] Review the Evernote app code before we release it to the marketplace Created: 01/Apr/14 Updated: 17/Apr/14 Resolved: 17/Apr/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | mcalvo | Assignee: | mcalvo |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
You can find the code here:
https://svn.rivetlogic.com/repos/rivets/archives/hrportal/branches/6.2 CE GA 1/liferay-plugins-sdk-6.2.0/portlets/evernote-portlet/ This app is documented here: http://wiki.rivetlogic.com/display/LRA/Evernote+Organizer Once you are done, if you find something that needs to be changed, document it here. Then implement the required changes. Because the key creation process that in documented in the wiki page can take up to 1 week, you can ask Pablo Nunez for the Evernote key that he already has. Preferred Updates UI - Authorization popup window should be updated dynamically when a user is authorized - done - Once the popup is closed, the page should be refreshed automatically - done - Note preview could show loading icon when there is delay (seems like there is some lagging and there WILL be lagging if we have slow connection) - done - Create Note and Create Notebook can go into different page - done - Delete action should show confirmation message and delete the note upon the user's confirmation - done - Note preview background has been updated - done - Alert message for delete note shows the delete target note title - done Backend - Missed to cover EE version in "liferay-plugin-package.properties" - done - Code clean up (move utility methods into uitlity class and "doView" method) with more comments - done - Bypass the logics when the user is not signed in since we only supports signed in users - done Good to have - in the future :-) - Periodic ping to Evernote server to update the list of note would be good to cover the case when the user updates evernote using the web site or mobile devices and have ping interval configurable |
| Comments |
| Comment by Dong-Jun Kim [X] (Inactive) [ 15/Apr/14 ] |
|
I added my observation under "Preferred Updates" section. Please let me know for any questions.
Thanks, |
| Comment by mcalvo [ 15/Apr/14 ] |
| Please implement the suggested changes |
| Comment by Dong-Jun Kim [X] (Inactive) [ 17/Apr/14 ] |
|
I updated the description with "- done" at the end of each item that was in the description. Please have another round of testing and let me know if any issue found.
Thanks, |