[LRA-154] Update Google Drive back end code Created: 28/Apr/14 Updated: 30/Apr/14 Resolved: 30/Apr/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | Google Drive Quick Links |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Dong-Jun Kim [X] (Inactive) | Assignee: | mcalvo |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
1. Need to be careful with throwing exceptions from the controller class. Instead of throwing exceptions, we need to handle it and put them as SessionErrors so the front end can show appropriate error messages. So, please update exception handling logic in the controller class. Rather than having just error logged, please add proper SessionError so proper error messages can be shown in the front end when the user is redirected to the target page
2. Please update the logic in the following code. Search container will throw exception if the results is null (it doesn't happen in the current logic, but we need to be careful though). Instead of calling the service directly from UI, please have it passed from the doView method in the controller class so we can handle exception (including null check) properly and show proper error messages to the users just in case of any errors. view.jsp, lines from 46 to 50 <liferay-ui:search-container-results total="<%=DriveLinksLocalServiceUtil.userDriveLinksCount(userId)%>" results="<%=DriveLinksLocalServiceUtil.userDriveLinks(userId, searchContainer.getStart(),searchContainer.getEnd()) %>" /> |
| Comments |
| Comment by Dong-Jun Kim [X] (Inactive) [ 30/Apr/14 ] |
|
Update on SessionErrors for add and delete links
Update on table name column size to 200 due to an error observed from a file with a long file name (more than 75 character) Thanks, |