[LRA-155] Test the Google Drive Quick Links app before we submit it to the marketplace Created: 29/Apr/14 Updated: 09/May/14 Resolved: 08/May/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | Google Drive Quick Links |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | mcalvo | Assignee: | mcalvo |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Resolution Date: |
| Description |
|
Follow the steps outlined here:
http://wiki.rivetlogic.com/display/HRPORTAL/QA+process Use this repository: https://github.com/rivetlogic/liferay-google-drive-quick-links The app documentation is here: http://wiki.rivetlogic.com/display/LRA/Google+Drive+Quick+Links Please update the app´s wiki with new screen shots that show the app´s new look and feel, and use Rivet's documents like case studies and similar for the screenshots. You can ask Charles for the keys needed to test the API. |
| Comments |
| Comment by mcalvo [ 30/Apr/14 ] |
|
Wait for this pull request to be merged, before starting the QA process:
https://github.com/rivetlogic/liferay-google-drive-quick-links/pull/5 |
| Comment by Juan Carrillo [X] (Inactive) [ 30/Apr/14 ] |
|
Some global variables founded, and some js imports did incorrectly <script type="text/javascript"> function onApiLoad() { gapi.load('auth', {'callback': function() { }}); gapi.load('picker', {'callback': function() { }}); } </script> <script type="text/javascript" src="https://apis.google.com/js/api.js?onload=onApiLoad"></script> Also missing some constants in Java Code and Javascript String documentId = ParamUtil.getString(request, "documentId"); this.scope = ['https://www.googleapis.com/auth/drive']; |
| Comment by Juan Carrillo [X] (Inactive) [ 06/May/14 ] |
| Code is updated and the errors mentioned above are not happening. |
| Comment by mcalvo [ 07/May/14 ] |
| Katalina we need to restest it again after the changes Juan made. His pull request is pending, please work on it as soon as it has been merged. |
| Comment by Katalina Marcos [ 08/May/14 ] |
| delete icon with red line at top |
| Comment by Katalina Marcos [ 08/May/14 ] |
| By testing the portlet in chrome the delete icon was showed with a red line in the top. However is not exclusive from chrome, I could reproduce it in other browsers with zoom in and zoom out actions. Please take a look of attached image. |
| Comment by Katalina Marcos [ 08/May/14 ] |
|
Also I found a problem with IE9 but it's a google drive issue. So I add a related comment to the app's documentation http://wiki.rivetlogic.com/display/LRA/Google+Drive+Quick+Links (Browser comp ability) |
| Comment by Katalina Marcos [ 08/May/14 ] |
| Not an issue actually, but the portlet present this message "Welcome to My Google Drive Quick Links" and it cannot be removed. Maybe it could be annoying for some users? |
| Comment by Katalina Marcos [ 08/May/14 ] |
|
Revision finished.
It was reviewed it in Liferay CE 6.2.0 CE and Lifeay EE 6.2.10.1 It was reviewed it in Safari 6.13, Firefox 29, Chrome 34 and IE9+ Just an small issue was found. It is related to the delete icon. A Google Drive issue with IE9 was documented. A possible enhancement about welcome message was also described. |
| Comment by mcalvo [ 09/May/14 ] |
| We decided to remove the "Welcome to My Google Drive Quick Links" from the page. The delete icon seems to be a Liferay issue and it is a minor bug. |