[LRA-187] Skype minor bugs Created: 19/May/14 Updated: 28/May/14 Resolved: 28/May/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | Skype Chat & IM |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Juan Carrillo [X] (Inactive) | Assignee: | mcalvo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
Screen Shot 2014-05-20 at 10.39.53 AM.png
Screen Shot 2014-05-20 at 11.08.34 AM.png
issue1.png
issueaz.png
issuepaginator.png
paginator.png
|
| Description |
|
1) When the portlet is added to the page, the users are not being displayed until the browser is refreshed again. (image attached)
2) The search results table is not displaying the users from A-Z neither Z-A when there is not option selected. It is preferred to be from A-Z like Control Panel does. 3) The page navigator is not displayed in a single column when is in phone view. Think DJ mentioned that this should be in a single row, it is for pc screen now, but not for phone. Issue 1,3 are UI errors, 2 is backend. 1,2,3 are solved 4) Extend pagination correctly to add sync pages correctly. The changes have to apply to USER and GROUP pagination. |
| Comments |
| Comment by Juan Carrillo [X] (Inactive) [ 19/May/14 ] |
| Attachment for the 3 bugs |
| Comment by mcalvo [ 20/May/14 ] |
| Juan please address issues 1 and 2, and asking Alejandro to address issue #3. |
| Comment by Alejandro Soto [X] (Inactive) [ 20/May/14 ] |
| Pagination on phone styled |
| Comment by Alejandro Soto [X] (Inactive) [ 20/May/14 ] |
| desktop pagination centered |
| Comment by Juan Carrillo [X] (Inactive) [ 20/May/14 ] |
| Changes done, waiting pull request https://github.com/rivetlogic/liferay-skype/pull/10 |
| Comment by Juan Carrillo [X] (Inactive) [ 21/May/14 ] |
| The logic to sync pagination is founded, but the correct way to do this is to extend the module and modify there, my knowledge of YUI is not advanced, so may be an UI guy should change this, so I'm opening this ticket for somebody else take care of this. |
| Comment by Juan Carrillo [X] (Inactive) [ 21/May/14 ] |
| The pull request with the paginatiion fix is there https://github.com/rivetlogic/liferay-skype/pull/11 Alejandro can take this code and add correctly in the extended module |
| Comment by Alejandro Soto [X] (Inactive) [ 21/May/14 ] |
| https://github.com/rivetlogic/liferay-skype/pull/12 pull request sent with the new pagination module changes |
| Comment by mcalvo [ 26/May/14 ] |
| The groups paginator has duplicated selectors: it has First twice, Last twice. See attached image paginator.png. Also the Next button is a the left side it should be a the right side. |
| Comment by Alejandro Soto [X] (Inactive) [ 27/May/14 ] |
| Bug fixed https://github.com/rivetlogic/liferay-skype/pull/15 |
| Comment by mcalvo [ 27/May/14 ] |
| Right now when you load a skype group, it automatically hides the groups list. The group list should not be hidden. |
| Comment by Alejandro Soto [X] (Inactive) [ 28/May/14 ] |
| Code fix merged https://github.com/rivetlogic/liferay-skype/pull/16 |