Modal.jpg
Pagination.jpg
[LRA-20] Create Scheduled job manager portlet Created: 18/Dec/13 Updated: 12/Feb/14 Resolved: 12/Feb/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | mcalvo | Assignee: | mcalvo |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
Modal.jpg
Pagination.jpg
|
| Resolution Date: |
| Description |
|
It must work with Liferay 6.1 GA3 community.
These plugins will share the same repo as HR Portal but should run on any 6.1 GA3 without HR portal. Upload your code here: https://svn.rivetlogic.com/repos/rivets/logicstacks/hrportal/trunk/portlets/ Present a unified interface that 1) Lists all the quarts jobs in the system 2) Tells the administrator which node is the one currently running the jobs 3) Allow the admin to enable or disable a quartz job |
| Comments |
| Comment by mcalvo [ 14/Jan/14 ] |
|
Improvements after discussion with Alaaeldin: + Remove Unschedule button + Remove Update button + Make columns sortable + Make it a control panel portlet |
| Comment by mcalvo [ 23/Jan/14 ] |
| The portlet has been renamed to Scheduled job manager. Please make the required code changes to reflect the new name, but don't change the SVN project name. |
| Comment by Steven Barba (Inactive) [ 24/Jan/14 ] |
|
ok ready, I changed the portlet nameID and properties files, the new nameID is «Scheduled Job Manager» |
| Comment by mcalvo [ 29/Jan/14 ] |
|
1) Remove any commented out old code/statements
//System.out.println("REDIRECT: " + redirect); - init.jsp 2) Typo in the method name QuartzSchedulerUtil.getSchedulerJobCoparator - view.jsp 3) We could possibly make this portlet for just administrators in portlet.xml 4) Why did we use the upload request for action request to update jobs? - QuartzSchedulerPortlet.java UploadPortletRequest uploadRequest = PortalUtil.getUploadPortletRequest(actionRequest); http://localhost:8080/group/control_panel/manage?p_auth=YByq39Zx&p_p_id=scheduledjobmanager_WAR_quartzschedulerportlet&p_p_lifecycle=1&p_p_state=maximized&p_p_mode=view&refererPlid=13170&_scheduledjobmanager_WAR_quartzschedulerportlet_javax.portlet.action=jobAction&jobName_0=com.liferay.portlet.journal.messaging.CheckArticleMessageListener&groupName_0=com.liferay.portlet.journal.messaging.CheckArticleMessageListener&storageType_0=MEMORY_CLUSTERED&jobName_1=com.liferay.portlet.assetpublisher.messaging.CheckAssetEntryMessageListener&groupName_1=com.liferay.portlet.assetpublisher.messaging.CheckAssetEntryMessageListener&storageType_1=MEMORY_CLUSTERED&jobName_2=com.liferay.knowledgebase.admin.messaging.CheckAttachmentsMessageListener&groupName_2=com.liferay.knowledgebase.admin.messaging.CheckAttachmentsMessageListener&storageType_2=MEMORY_CLUSTERED&index=2&button=resume We need to probably use short url and post everything normally using hidden fields instead of using the url. 5) Add constants to replace "string" in java classes. 6) Replace auto-generated printstacktrace with debug or error logs as appropriate e.printStackTrace(); 7) The portlet in control panel supports import/export - we need to see how Liferay enables this and probably disable this for this portlet. 8) Alignment of previous next buttons with the pagination needs minor fix 9) Issue with the display of the dialog box after hitting the Shutdown button. It is not positioned on top of the text. |
| Comment by mcalvo [ 31/Jan/14 ] |
| Pablo get in touch with Shagul, so he can explain you what are the changes that he is requesting. |
| Comment by mcalvo [ 03/Feb/14 ] |
| Please work on issues 8 and 9 only. |
| Comment by oscar.solano [ 07/Feb/14 ] |
| Corrected pagination and modal |
| Comment by mcalvo [ 10/Feb/14 ] |
| Katalina work on issues 1 to 7, contact Shagul if you have any question. |
| Comment by Katalina Marcos [ 10/Feb/14 ] |
| Reopened to work on some backed issues |
| Comment by oscar.solano [ 12/Feb/14 ] |
| Fixed headers showing on top of overlay |
| Comment by Katalina Marcos [ 12/Feb/14 ] |
|
Several changes were made in this portlet:
1. Renaming the project name because it was as quartz-scheduler-portlet instead of scheduled-job-manager-portlet. In this commit we are going to add the renamed plugin. 2. Fixing RivetLogic copyright version fro 2 to 3. 3. Removing //System.out.println("REDIRECT: " + redirect); 4. Correcting method name QuartzSchedulerUtil.getSchedulerJobCoparator 5. Making portlet just for administrators in portlet.xml 6. Add constants to replace "string" in java classes. 7. Replace auto-generated printstacktrace with debug or error logs as appropriate e.printStackTrace(); 8. Refactoring portlet: Portlet was obtaining parameters values from UploadPortletRequest because parameters were added by javascritp to the URL. It was needed change to POST method, use aui:input for generate tags, change main.js. Remove unused code. |
| Comment by Katalina Marcos [ 12/Feb/14 ] |
|
About the requested issue: "7) The portlet in control panel supports import/export - we need to see how Liferay enables this and probably disable this for this portlet." After review the code related to display the export/import option, it seems liferay has a bug and it is not disabling it because the next expression results true even when the portlet has the default handler: !(portlet.getPortletDataHandlerInstance() instanceof DefaultConfigurationPortletDataHandler); As solution we added some css code to hide the menu. Besides, language property "javax.portlet.description" was corrected. |