[LRA-213] Check this pull request Created: 23/Jul/15 Updated: 24/Aug/15 Resolved: 24/Aug/15 |
|
| Status: | Closed |
| Project: | Liferay Apps |
| Component/s: | Mobile People Directory |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major |
| Reporter: | mcalvo | Assignee: | Jose Ross [X] (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Check and apply his pull request:
https://github.com/rivetlogic/mobile-people-directory/pull/22/files |
| Comments |
| Comment by Jose Ross [X] (Inactive) [ 31/Jul/15 ] |
|
The change included in the pull request #22 was tested and it doesn't affect any of the functionality in the application, it can be merged without problems. Additionally two issues were found and fixed in the application: - In the People Directory portlet the search pagination only worked the first time a search was made. - The returned value for activeUsersCount was wrong in some of the JSON services. https://github.com/rivetlogic/mobile-people-directory/pull/23 |
| Comment by mcalvo [ 14/Aug/15 ] |
|
Reviewer's Message There was an issue with your app. You recently submitted an app "Mobile People Directory" to the Liferay Marketplace. Mobile People Directory was tested on Liferay Portal 6.2 CE GA1, JBoss 7.1. At this time, your app has not been approved for the Liferay Marketplace due to: * Errors are thrown in console during deployment. ERROR [MSC service thread 1-5][BasePortalLifecycle:47] java.util.ConcurrentModificationException 16:46:52,398 INFO [stdout] (MSC service thread 1-5) java.util.ConcurrentModificationException 16:46:52,398 INFO [stdout] (MSC service thread 1-5) at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:953) 16:46:52,399 INFO [stdout] (MSC service thread 1-5) at java.util.LinkedList$ListItr.next(LinkedList.java:886) 16:46:52,399 INFO [stdout] (MSC service thread 1-5) at org.apache.commons.configuration.CompositeConfiguration.getKeys(CompositeConfiguration.java:212) 16:46:52,400 INFO [stdout] (MSC service thread 1-5) at org.apache.commons.configuration.ConfigurationConverter.getProperties(ConfigurationConverter.java:112) 16:46:52,401 INFO [stdout] (MSC service thread 1-5) at com.germinus.easyconf.ComponentProperties.getProperties(ComponentProperties.java:131) 16:46:52,401 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.configuration.ConfigurationImpl.getProperties(ConfigurationImpl.java:272) 16:46:52,402 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.configuration.ConfigurationImpl.getProperties(ConfigurationImpl.java:288) 16:46:52,402 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.util.PropsUtil._getProperties(PropsUtil.java:330) 16:46:52,403 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.util.PropsUtil.getProperties(PropsUtil.java:82) 16:46:52,403 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.servlet.filters.authverifier.AuthVerifierFilter.init(AuthVerifierFilter.java:78) 16:46:52,404 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.PortalClassLoaderFilter.doPortalInit(PortalClassLoaderFilter.java:146) 16:46:52,404 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44) 16:46:52,405 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:64) 16:46:52,406 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:56) 16:46:52,406 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54) 16:46:52,407 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.PortalClassLoaderFilter.init(PortalClassLoaderFilter.java:85) 16:46:52,408 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.getFilter(InvokerFilterHelper.java:195) 16:46:52,408 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.initFilter(InvokerFilterHelper.java:232) 16:46:52,409 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.readLiferayFilterWebXML(InvokerFilterHelper.java:323) 16:46:52,410 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilter.doPortalInit(InvokerFilter.java:172) 16:46:52,410 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44) 16:46:52,411 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:64) 16:46:52,411 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:56) 16:46:52,412 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54) 16:46:52,412 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilter.init(InvokerFilter.java:115) 16:46:52,413 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:447) 16:46:52,413 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3269) 16:46:52,414 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3865) 16:46:52,414 INFO [stdout] (MSC service thread 1-5) at org.jboss.as.web.deployment.WebDeploymentService.start(WebDeploymentService.java:90) 16:46:52,415 INFO [stdout] (MSC service thread 1-5) at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) 16:46:52,415 INFO [stdout] (MSC service thread 1-5) at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) 16:46:52,416 INFO [stdout] (MSC service thread 1-5) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 16:46:52,416 INFO [stdout] (MSC service thread 1-5) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 16:46:52,417 INFO [stdout] (MSC service thread 1-5) at java.lang.Thread.run(Thread.java:745) 16:46:52,417 INFO [stdout] (MSC service thread 1-1) 16:46:52,396 INFO [MSC service thread 1-1][PortletHotDeployListener:343] Registering portlets for people-directory-portlet 16:46:52,419 INFO [stdout] (MSC service thread 1-5) 16:46:52,417 ERROR [MSC service thread 1-5][InvokerFilterHelper:200] Unable to initialize filter com.liferay.portal.kernel.servlet.PortalClassLoaderFilter 16:46:52,421 INFO [stdout] (MSC service thread 1-5) java.lang.IllegalStateException: Unable to initialize portal 16:46:52,422 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:49) 16:46:52,422 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:64) 16:46:52,423 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:56) 16:46:52,424 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54) 16:46:52,424 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.PortalClassLoaderFilter.init(PortalClassLoaderFilter.java:85) 16:46:52,425 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.getFilter(InvokerFilterHelper.java:195) 16:46:52,426 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.initFilter(InvokerFilterHelper.java:232) 16:46:52,427 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterHelper.readLiferayFilterWebXML(InvokerFilterHelper.java:323) 16:46:52,428 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilter.doPortalInit(InvokerFilter.java:172) 16:46:52,432 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44) 16:46:52,433 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:64) 16:46:52,434 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:56) 16:46:52,435 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54) 16:46:52,436 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilter.init(InvokerFilter.java:115) 16:46:52,436 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:447) 16:46:52,437 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3269) 16:46:52,438 INFO [stdout] (MSC service thread 1-5) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3865) 16:46:52,438 INFO [stdout] (MSC service thread 1-5) at org.jboss.as.web.deployment.WebDeploymentService.start(WebDeploymentService.java:90) 16:46:52,440 INFO [stdout] (MSC service thread 1-5) at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) 16:46:52,441 INFO [stdout] (MSC service thread 1-5) at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) 16:46:52,443 INFO [stdout] (MSC service thread 1-5) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 16:46:52,444 INFO [stdout] (MSC service thread 1-5) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 16:46:52,445 INFO [stdout] (MSC service thread 1-5) at java.lang.Thread.run(Thread.java:745) 16:46:52,445 INFO [stdout] (MSC service thread 1-5) Caused by: java.util.ConcurrentModificationException 16:46:52,446 INFO [stdout] (MSC service thread 1-5) at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:953) 16:46:52,447 INFO [stdout] (MSC service thread 1-5) at java.util.LinkedList$ListItr.next(LinkedList.java:886) 16:46:52,449 INFO [stdout] (MSC service thread 1-5) at org.apache.commons.configuration.CompositeConfiguration.getKeys(CompositeConfiguration.java:212) 16:46:52,452 INFO [stdout] (MSC service thread 1-5) at org.apache.commons.configuration.ConfigurationConverter.getProperties(ConfigurationConverter.java:112) 16:46:52,453 INFO [stdout] (MSC service thread 1-5) at com.germinus.easyconf.ComponentProperties.getProperties(ComponentProperties.java:131) 16:46:52,454 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.configuration.ConfigurationImpl.getProperties(ConfigurationImpl.java:272) 16:46:52,455 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.configuration.ConfigurationImpl.getProperties(ConfigurationImpl.java:288) 16:46:52,456 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.util.PropsUtil._getProperties(PropsUtil.java:330) 16:46:52,456 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.util.PropsUtil.getProperties(PropsUtil.java:82) 16:46:52,457 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.servlet.filters.authverifier.AuthVerifierFilter.init(AuthVerifierFilter.java:78) 16:46:52,457 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.servlet.PortalClassLoaderFilter.doPortalInit(PortalClassLoaderFilter.java:146) 16:46:52,458 INFO [stdout] (MSC service thread 1-5) at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44) 16:46:52,459 INFO [stdout] (MSC service thread 1-5) ... 22 more |
| Comment by Jose Ross [X] (Inactive) [ 19/Aug/15 ] |
| The problem described could not be replicated, the application was deployed several times on new installations of Liferay 6.2 CE GA1 running JBoss AS 7.1 without any issues. |