[LRA-66] Several front end improvements to People Directory portlet Created: 09/Jan/14 Updated: 23/Jan/14 Resolved: 09/Jan/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | mcalvo | Assignee: | Alejandro Soto [X] (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
+) Number of Rows: <aui:input type="text" name="rowCount" value="<%=rowCount%>" label=""/>
Alloy UI already supports label. Why not use that and language.properties? +) The below global variables should not be used. Any other similarly written portlet may override the resourceURL. <script type="text/javascript"> var rowCount = parseInt("<%=rowCount%>"); var portletNamespace = "<portlet:namespace />"; var resourceUrl = "<portlet:resourceURL />"; </script> +) Profile.jsp Move the styles to css file. +) View.jsp Consolidate style in css file 8) main.js use templates for the html code in js remove any commented alert statements |
| Comments |
| Comment by Alejandro Soto [X] (Inactive) [ 09/Jan/14 ] |
| improvements added to 6.1 and 6.2 people directory plugins |