[LRA-67] Several backend improvements to People Directory portlet Created: 09/Jan/14 Updated: 23/Jan/14 Resolved: 14/Jan/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | mcalvo | Assignee: | Raghu Kanakamedala [X] (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
+ We just need configuration.jsp and no edit.jsp. Both the preferences can be on one page
Number of search results per page = View all results per page = Need to update wiki accordingly for this configuration + The default preferences should come from one portlet.xml. right now it is read from constant DEFAULT_ROW_COUNT = "2"; as well as portlet.xml + init.jsp This has a lot of imports that are never used in this portlet. This needs to be slim and have only the ones that are needed. + View.jsp sql query params could go in a util class. the logic to determine city and phone does not break. Also this could go in a until class. com.liferay.portal.kernel.servlet.SessionErrors - this could be an import to make the code more readable + PeopleDirectory portlet performContentSearch - remove commented out method + e.printStacktrace() Replace it with log statements + liferay-plugin-package.properties Use rivet logic for module and provide the rivetlogic.com for the url PeopleDirectory_feedback.txt |
| Comments |
| Comment by Raghu Kanakamedala [X] (Inactive) [ 14/Jan/14 ] |
| All the code issues are now fixed |