[LRA-91] Move the HR portal code to GitHub Created: 20/Feb/14 Updated: 28/Jul/14 Resolved: 27/May/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | HR Portal |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | mcalvo | Assignee: | mcalvo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Move its code to GitHub repository:
https://github.com/rivetlogic/hr-portal Before doing that check all jsp, java and js file have this header disclaimer (remember the license version has changed GPLv3): /** * Copyright (C) 2005-2014 Rivet Logic Corporation. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; version 3 * of the License. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, * Boston, MA 02110-1301, USA. */ Additionally: + Change "magic" numbers and String values for constants. + Remove any console.log + Remove welcome-file-list from web.xml + Change any e.printStackTrace(); for log |
| Comments |
| Comment by Juan Carrillo [X] (Inactive) [ 21/Feb/14 ] |
| Waiting for pull request approval |
| Comment by Juan Carrillo [X] (Inactive) [ 27/Feb/14 ] |
|
The pull request was not accepted, HR Portal needs some fixes: main.js on hr-portal-blue-responsive-theme has comment code main.js on velocity-templates-theme has empty methods some indentation issues in css for themes hr-commom-hook does not have default file, just _en |
| Comment by mcalvo [ 27/Feb/14 ] |
|
THE CURRENT REPOSITORY IS NOT IN GitHub. Please contact Juan Carrillo, he has the latest version of the code. The pending fixes are: + main.js on hr-portal-blue-responsive-theme has comment code + main.js on velocity-templates-theme has empty methods + some indentation issues in css for themes + hr-commom-hook does not have default file, just _en |
| Comment by Juan Carrillo [X] (Inactive) [ 27/Feb/14 ] |
|
For getting the last code use this:
fork from Rivet Logic repo, in a terminal inside the repo run this: git remote add juanhrportal https://github.com/jkamcc/hr-portal.git git fetch juanhrportal git checkout master git merge juanhrportal/master that should be fine |
| Comment by Christopher Jimenez [X] (Inactive) [ 05/Mar/14 ] |
|
Please check the pull request.
Thanks |
| Comment by Juan Carrillo [X] (Inactive) [ 12/Mar/14 ] |
|
the pull request is done with the css changes.
there is one error when deploying hrportal-services-portlet, doesn't look critical because this plugin is never used Access denied java.util.PropertyPermission portal:velocity.engine.logger read the error is related with PACL permissions, and happens when deploying the plugin in a clean bundle, but we can handle this, because like I said this portlet is never used. |