[LRA-97] Several changes to the announcer app Created: 21/Feb/14 Updated: 06/Mar/14 Resolved: 06/Mar/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | Announcer |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major |
| Reporter: | mcalvo | Assignee: | Charles Javier Rodriguez Beauregard [X] (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
- Update the main.css to reflect the new name announcer. There are still some onboarding reference.
- rename folder structure etc to reflect new portlet name /html/onboarding … /html/announcer - liferay-portlet.xml and portlet.xml still have reference for on boarding. - Service.xml still has reference to on boarding - some of the package names are com.hrportal - this should be com.rivetlogic - indication of which main article needs to be obvious (default article) - content.jsp - displayAnnClose(); is this a typo for And? - Full Content button may be renamed to Launch. use language properties so that this can be easily changed and localized if needed (value="Full content") (life ray blue button) - The action buttons in the modal panel can say Select instead of "Add" (replace with checkbox) - After selecting there is no way to unselect in the modal panel. A user has to close all. (solve with checkbox) - The pagination of the selector modal panel is not styled - showArticles.jsp code does not scale. what happens when you have thousands of articles in the group. (article search) - liferay-plugin-package.properties - update the module group, author, page url - Review OnboardingPortlet.java - this class needs to be renamed articleWithVersionBuilder.deleteCharAt(0); // remove the initial comma - do we need this? LOG.error(e); LOG.error(e); - appears twice in a catch block - Need to understand why we need upload request when there is nothing being uploaded in OnBoardingPortlet.java UploadPortletRequest upreq = PortalUtil.getUploadPortletRequest(request); - LOG.debug("ArticleIds: "+articleIds); LOG.debug("Articles with version: "+articleWithVersion); LOG.debug("Article consecutive: "+articleConsecutive); LOG.debug("Preferences saved"); Wrap the above with sing LOG.isDebugEnabled() - We may need to change the statuses to “COMPLETED" and "NOTCOMPLETED" Also for any .java, .jsp or .js file that is AUTOGENERATED by Liferay AND that we HAVE MODIFIED, ADD THE FOLLOWING line above Liferay's copyright disclaimer: /* Copyright (c) 2014 Rivet Logic Corporation. All rights reserved. */ /** * Copyright (c) 2000-2013 Liferay, Inc. All rights reserved. * * This library is free software; you can redistribute it and/or modify it under *.... */ |