new-dependencies-v2.zip
new-messages_to_review_events_portlet-v2.txt
[LRA-99] Please check the following changes were made to the Events apps Created: 03/Mar/14 Updated: 27/Mar/14 Resolved: 25/Mar/14 |
|
| Status: | Resolved |
| Project: | Liferay Apps |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | mcalvo | Assignee: | mcalvo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
new-dependencies-v2.zip
new-messages_to_review_events_portlet-v2.txt
|
| Resolution Date: |
| Description |
|
Get the code from SVN:
https://svn.rivetlogic.com/repos/rivets/archives/hrportal/branches/6.2%20CE%20GA%201/liferay-plugins-sdk-6.2.0/portlets/events-management-portlet/ 1) Let's take hr-portal reference from portlet.properties and other places 2) Why are we using a custom query to find by eventId and email when the same can be done easily in service builder? 3) The email that went out did not have appropriate subject and body 4) As soon as an event is stored, the UI renders sometimes two rows and sometimes no rows. Refreshing the screen tries to re-post. we need to show appropriate results and the redirected one should be a render url to the same page. 5) All the action urls should redirect to render url at the end of action so that refreshing the screen does not trigger another post. 6) Provide language properties for all definition of terms 7) Event creation should not allow events in past. This sends the event directly to past events and does not allow a user to edit. 8) We need a message to say an email id that is already registered for an event cannot be registered again. 9) Can we use Liferay's repeatable fields for adding more participant? 10) Move styles to css - edit_event.jsp type="submit" style="height: 25px;" 11) typo in file name - emai-from.jspf 12) upload_csv.jsp - this is not used. remove from repo. <div> <label for="firstname">Upload file:</label> <input type="file" name="csvFile" /> </div> 13) Check PACL security is enabled. 14) It is sending the email reporting an email address different than what it is configured in portlet preferences. 15) The default "Updated Invitation email" is not good. It is not asking to confirm the assistance. 16) Check the copyrights are in .js, .jsp, and .java. Additionally: + Change "magic" numbers and String values for constants. + Remove any console.log + Remove welcome-file-list from web.xml + Change any e.printStackTrace(); for log |
| Comments |
| Comment by Katalina Marcos [ 07/Mar/14 ] |
|
Reviewed. Several things were fixed:
1. Removing magic numers and strings 2. Changing deprecated calls in EventLoclServiceImpl 3. Rejection template was not procesed (Christoper solved it) (mechansim for tempate processing is not the best but I didn't change it because it had a major impact) 4. Paginations doesn't work 5. If confirmation or rejection links are visited twice or more times, they present wrong message. 6. Event display portlet should only show public events. 7. Load users in csv files wasn't working fine: the repeated users got participant-status-0 and an invitation and then a cancellation of the event 8. Disable to view past events. 9. Confirmation page has a new message to make the action clearer 10. Adding default number of rows as a preference (it was hardcoded to 5) |
| Comment by mcalvo [ 17/Mar/14 ] |
| Update Events messages using the attached properties. |
| Comment by Katalina Marcos [ 25/Mar/14 ] |
|
New revision, including developer checklist.
Addressed issues: 1. Updating messages and templates. Changing all successfull by successful. Updating another language properties names 2. Fixing an error in the email when a user was registed in event view form: the formed url had null. 3. Refactoring services because the namespace and the package name were incorrect 4. Fixing issue with buttons (responsive review) 5. Adding missing disclaimer information 6. Adding title to error page |
| Comment by Katalina Marcos [ 27/Mar/14 ] |
|
I've finished this application's documentation in http://wiki.rivetlogic.com/display/LRA/Events Also I've done a pull request to rivetlogic github repository |