[CMA-45] Optional parameter is actually required in WorkflowService.endTask

Fri, 21 May 2010 12:49:35 -0400

Acording to javadocs @ http://docs.rivetlogic.com/projects/raar/current/javadocs/com/rivetlogic/core/cma/api/WorkflowService.html, the parameter transitionId in endTask is optional (i.e. it can be null, meaning that the default transition should be taken).

But the actual implementation @ https://svn.rivetlogic.org/repos/rivets/core/cma/cma/trunk/modules/cma-impl/src/main/java/com/rivetlogic/core/cma/impl/WorkflowServiceImpl.java checks that parameter as required (line 172):

public WorkflowTask endTask(Ticket ticket, String taskId,
String transitionId) throws InvalidTicketException,
CmaRuntimeException {
// check parameters
ParameterCheck.mandatory("ticket", ticket);
ParameterCheck.mandatoryString("taskId", taskId);
----->>>>ParameterCheck.mandatoryString("transitionId", transitionId);

String methodName = CmaConstants.METHOD_WORKFLOW_ENDTASK;
// create parameters
Vector<NameValuePair> parameters = createGeneralParameters(ticket, methodName);
parameters.add(new NameValuePair(CmaConstants.PARAM_TASKID, taskId));
parameters.add(new NameValuePair(CmaConstants.PARAM_TRANSITIONID, transitionId));
parameters.add(new NameValuePair(CmaConstants.PARAM_USETRANSACTION, true));

return (WorkflowTask) execute(ticket, methodName, parameters);
}

As a result of this, we cannot invoke the default transition when ending a task.

Rivet Logic Corporation JIRA

[CMA-45] Optional parameter is actually required in WorkflowService.endTask