[LRA-211] Apply changes to external contribution and test the app continues to work

Fri, 31 Jul 2015 12:54:08 -0400

We recently merged this change:
https://github.com/rivetlogic/liferay-scheduled-job-manager/commit/698b53ad0360ed6dca427eb5fc9007d65d27ab6b

About it Vagif ask to do the following:
Generally a solid contribution, with some issues:
1. the abstract class name DateComparator is misleading. It should be called a JobComparator or similar.
2. The compare method of the DateComparator class may need some fixing. It currently assumes there won't be date values before epoch(which may be a correct assumption is the given Job context):
    Date date0 = getDateValue(jobBean0);
    if (date0 == null) {
        date0 = new Date(0);
    }
3. The getShortName method of the SchedulerJobBeanImpl class has been modified assuming the name field will always have a '.' in it and never be empty, which may be correct, but needs validation.
          if (jobName != null && !jobName.isEmpty()) {
               return jobName.substring(jobName.lastIndexOf(".")).substring(1);
          if (jobName != null) {
               return jobName.substring(jobName.lastIndexOf('.') + 1);
4. QuartzSchedulerUtil looks ok, but can be improved upon further. Generation of the message and sending seems out of place.
5. language.properties needs proper English review, some has been fixed by the contribution.
6. CSS needs review, he has removed lots of CSS :-)
  view.jsp needs review, because of some CSS class changes.

We need to apply what Vagif ask us to do and test the app continues to work.

Here is the app documentation:
http://wiki.rivetlogic.com/display/LRA/Scheduled+job+manager

Rivet Logic Corporation JIRA

[LRA-211] Apply changes to external contribution and test the app continues to work